Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScenarioRunner Docker configuration #168

Merged
merged 8 commits into from
Nov 1, 2023
Merged

Add ScenarioRunner Docker configuration #168

merged 8 commits into from
Nov 1, 2023

Conversation

adamlm
Copy link
Contributor

@adamlm adamlm commented Oct 27, 2023 •
edited
Loading

PR Details

Description

The Docker image contains all necessary dependencies and embeds any custom CARMA scenarios to run.

Related Issue

Closes #167
Closes CDAR-398

Related to usdot-fhwa-stol/carma-config#279

Motivation and Context

How Has This Been Tested?

Types of changes

  • New feature (non-breaking change that adds functionality)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide

@adamlm
#167 Add ScenarioRunner Docker configuration
8e2d19f 
The Docker image contains all necessary dependencies and embeds any
custom CARMA scenarios to run.
@adamlm adamlm requested a review from MishkaMN October 27, 2023 19:39
adamlm added 5 commits October 27, 2023 15:39
@adamlm
#167 Clean up Dockerfile
f3ef27e
@adamlm
#167 Fix script issues
7e3dfd6 
The scenario_runner.py script requires that the existing files in the
scenarios/ directory remain there. The installation script no longer
deletes them.
@adamlm
#167 Resolve ShellCheck linting issues
dfad3e7
@adamlm
#167 Fix typo in README
65d4bd1
@adamlm
#167 Comment out cyclist
d53219a 
It was causing CDASim to crash. It's not a big deal right now since we
are not using it in the MyScenario definition.
@adamlm adamlm self-assigned this Oct 31, 2023
@adamlm adamlm marked this pull request as ready for review November 1, 2023 13:15
@adamlm
#167 Reorganize Dockerfile items
647c7e7 
The Dockerfile now downloads CARLA's Python API before installing the
CARMA ScenarioRunner scenarios. This allows Docker to cache the CARLA
download layer, reducing build times when developers want to
develop new scenarios.
MishkaMN

This comment was marked as duplicate.

Sign in to view

MishkaMN
MishkaMN requested changes Nov 1, 2023
View reviewed changes
scenario-runner/.dockerignore Outdated Show resolved Hide resolved
@adamlm adamlm requested a review from MishkaMN November 1, 2023 15:21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@MishkaMN MishkaMN merged commit f015ed6 into develop Nov 1, 2023
6 checks passed
@adamlm adamlm deleted the 167-scenario-runner branch November 1, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishkaMN MishkaMN MishkaMN approved these changes

Assignees

@adamlm adamlm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dockerization of Scenario Runner CARLA Script
2 participants
@adamlm @MishkaMN