Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Email TLS and Auth Defaults #26

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

drewjj
Copy link
Collaborator

@drewjj drewjj commented Sep 11, 2024

PR Details

Description

Includes the latest fix for backwards compatibility for making smtp TLS and Auth optional.

How Has This Been Tested?

Unit tests and GCP GKE.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • My changes require updates and/or additions to the unit tests:
    • I have modified/added tests to cover my changes.
  • All existing tests pass.

@drewjj drewjj requested a review from payneBrandon September 11, 2024 22:16
Copy link
Collaborator

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid addition!

@payneBrandon payneBrandon merged commit 6c101ec into usdot-jpo-ode:develop Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants