Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant variables used should be exposed as application arguments. #16

Open
dan-du-car opened this issue Aug 12, 2020 · 2 comments · Fixed by #17
Open

Constant variables used should be exposed as application arguments. #16

dan-du-car opened this issue Aug 12, 2020 · 2 comments · Fixed by #17
Assignees
@dan-du-car
Labels
enhancement

Comments

@dan-du-car
Copy link
Collaborator

Update all constant variables values to application arguments. Need to keep all variables in the .env (hard coding in the Java code feels harder for implementers to work with)
@dan-du-car dan-du-car changed the title Bugfix for #12 Bugfix for https://github.com/usdot-jpo-ode/jpo-s3-deposit/issues/12 Aug 12, 2020
@dan-du-car
Copy link
Collaborator Author

#12

@dan-du-car dan-du-car linked a pull request Aug 12, 2020 that will close this issue
Modified code to expose amazon key constant variables as application arguments. #17
Merged
@dan-du-car dan-du-car changed the title Bugfix for https://github.com/usdot-jpo-ode/jpo-s3-deposit/issues/12 Bugfix for #12 Aug 12, 2020
@dan-du-car dan-du-car self-assigned this Aug 12, 2020
@snallamothu snallamothu changed the title Bugfix for #12 Constant variables used should be exposed as application arguments. Aug 12, 2020
dan-du-car pushed a commit that referenced this issue Feb 5, 2024
@dmccoystephenson
Merge pull request #16 from CDOT-CV/version/change-version-to-1.4.0-S…
1369d43 
…NAPSHOT

Changed version to 1.4.0-SNAPSHOT
@dmccoystephenson
Copy link
Contributor

Resolved by CDOT-CV#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dan-du-car dan-du-car

Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@snallamothu @dmccoystephenson @dan-du-car