Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options starting with --no are not passed to anvil #1321

Closed
bernard-wagner opened this issue Aug 27, 2024 · 3 comments
Closed

Options starting with --no are not passed to anvil #1321

bernard-wagner opened this issue Aug 27, 2024 · 3 comments
Assignees
@dbeal-eth

Comments

@bernard-wagner
Copy link
Contributor

Commander.js treats options starting with --no as negating options and consequently options such as --no-cors and --no-storage-caching are not passed to anvil. Instead, the options are registered as { "cors": false } and are then skipped by pickAnvilOptions().

Easy to test is with cannon clean --no-confirm.
@bernard-wagner
Copy link
Contributor Author

Got a potential fix, but maybe someone else has a better approach:

Changes to commander.js:
bernard-wagner/commander.js@f037c1b

Cannon changes:
bernard-wagner@467a112

@dbeal-eth dbeal-eth self-assigned this Aug 31, 2024
@bernard-wagner
Copy link
Contributor Author

PR for Commander.js changes.

tj/commander.js#2238

@noahlitvin
Copy link
Member

Closing, this is resolved in the latest release. Ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbeal-eth dbeal-eth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@noahlitvin @dbeal-eth @bernard-wagner