Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep forks with commits to non-default branches #33

Open
katrinleinweber opened this issue Jun 4, 2021 · 2 comments
Open

Keep forks with commits to non-default branches #33

katrinleinweber opened this issue Jun 4, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@katrinleinweber
Copy link

1k thanks for this tool :-)

Relevant work on a fork can be hidden in a non-default branch, if for example the author planned to submit a PR properly, but eventually didn't.

Would it be useful here to also check for such branches (not just the default branch), and keep forks in the results list, if any are found?

I've implemented such logic a while ago in a similar tool. While I can't port it to JS, I hope the example is still helpful to consider this idea.

The increased number of API calls can be mitigated, if necessary.

@katrinleinweber katrinleinweber changed the title Keep forks with commit to non-default branches Keep forks with commits to non-default branches Jun 4, 2021
@payne911
Copy link
Collaborator

payne911 commented Jun 4, 2021

1k thanks for this tool :-)

My pleasure! It was born out of personal necessity and curiosity. :)

Would it be useful here to also check for such branches

Absolutely ! Early on, I had considered it and thought it wasn't worth the API calls. But now things have changed.

The increased number of API calls [...]

That is indeed my main concern. For massively forked repositories, I'd rather see more results with a simplified view, than an incomplete but detailed list. And I assume this tool's relevance increases with the amount of forks, so I'm mostly aiming at keeping it this way.

My current plan is to allow people to save their "search preferences" through the little gear icon next to the search input text field, so that would be how I would add the feature of scanning all branches.

The simple act of querying for the list of branches of a fork is an API call. Then comparing branches would be another one. That's pretty much doubling the amount of calls the tool is currently making, hence why I'd keep it as opt-in option.

[...] can be mitigated, if necessary.

Is your proposal to require user input on each processed element before continuing? I personally do not think that is a very applicable thing for this tool.

@katrinleinweber
Copy link
Author

Yeah, that approach is for a slightly different goal than useful-forks': Assuming that each finding needs to be reviewed manually anyway, so waiting for the full list isn't needed.

… save their "search preferences" …

Also cool, thanks! :-)

@payne911 payne911 added enhancement New feature or request website labels Jul 7, 2021
@payne911 payne911 removed the website label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants