Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to github's night mode #25

Merged
merged 4 commits into from
Mar 19, 2021

Conversation

odnar-dev
Copy link
Contributor

closes #4

@TheTechRobo
Copy link

Isn't #21 already fixing this?

@payne911
Copy link
Collaborator

Isn't #21 already fixing this?

Yes and no. #21 proposes the creation of a new file, rather than editing the one associated with the Chrome plugin. I'm not 100% certain I'll be merging #21 as is, and will need to evaluate whether I can simply add its content directly into the Chrome script.

In the meantime, since it contained solutions to 2 current problems with the Chrome script, I suggested that he create separate PRs for those fixes. :)

@odnar-dev am I allowed to modify your PR ? (I believe you would have a checkbox for that somewhere on the right side.)

* Minor code style touch ups
* Fixed needlessly global CSS variables
* Fix IntelliJ commit bug
* Improve plugin description
@payne911 payne911 merged commit 8d1f5f6 into useful-forks:master Mar 19, 2021
@payne911
Copy link
Collaborator

Thanks for your contribution, @odnar-dev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chrome plugin enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to GitHub's Night-Mode
3 participants