Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oversight in dependency version for firebase/php-jwt #113

Open
wavedeck opened this issue Jan 29, 2024 · 0 comments
Open

Oversight in dependency version for firebase/php-jwt #113

wavedeck opened this issue Jan 29, 2024 · 0 comments

Comments

@wavedeck
Copy link
Contributor

According to composer.json, the dependency firebase/php-jwt is allowed to update implicitly until the last minor version of the current major (v6.x).

However, this would actually negate the mentioned minimum required PHP version (7.2) as described in the plugin README.

Starting with v6.5, php-jwt increased the minimum supported PHP version to 7.4 [email protected] on packagist

in the PR #112 , i noticed this and tried to mitigate it by only allowing patch releases within the current declared minor. This change was reverted in favor of discussing this beforehand.

Imho we have two different options, either, keep / update the current dependency version in composer.json and raise the minimum required PHP version of this plugin to 7.4 or lock the dependency version to patch-releases within v6.3 / v6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant