-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where should in-galaxy links in news posts go? #76
Comments
I guess default can be _blank. Tool links and so on should probably open in the same window. |
Related, we should add this by default as well: https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/ |
Can we go for _blank by default? |
After some discussion with will here, galaxyproject/training-material#912 I'm leaning towards agreeing with him. maybe this isn't so attractive. |
Not sure, _blank is what people expect and many site offer it. If we are concerned about the security, than we should use the linked workarounds above, no? |
The theory is that we should teach people the many ways they can open in a new tab (ctrl + click, right click + menu). If we use Teaching people is hard, but I've started to lean in favor of that, rather than forcing this behavior on everyone when it isn't desirable for everyone, and there are options.. |
The practice is that people complain that our website is broken. I'm not sure our mission should be to teach people how to use a web browser - especially not if we know that our users are not IT-affine. |
target="_top"
, loads the galaxy page in the current window, navigating away from the news item (browser back button will return them to their previous location)target="_blank"
, opens a new tab(noticed on nanopolish post which does neither of these things and we load galaxy-in-galaxy)
The text was updated successfully, but these errors were encountered: