Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share evaluators and file facts between RascalTextDocumentService and RascalWorkspaceService #541

Open
toinehartman opened this issue Dec 9, 2024 · 0 comments
Open

Share evaluators and file facts between RascalTextDocumentService and RascalWorkspaceService #541

toinehartman opened this issue Dec 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@toinehartman
Copy link
Contributor

The addition of a RascalWorkspaceService implementation in #1678 motivates an extraction of certain logic that is now only available to the RascalTextDocumentService. In particular, the evaluators in RascalLangueServices and FileFacts are candidates. These are very useful (or sometimes even necessary) to implement callbacks in the workspace service.

Given the decoupled nature of IBaseTextDocumentService and BaseWorkspaceService, and the postponed creation and coupling of RascalLanguageServices, this requires some careful thinking about dependencies and creation order.
@toinehartman toinehartman added the bug Something isn't working label Dec 9, 2024
@DavyLandman DavyLandman added enhancement New feature or request and removed bug Something isn't working labels Dec 9, 2024
toinehartman added a commit that referenced this issue Dec 9, 2024
@toinehartman
Move rename files callback to prevent multiple evaluators.
a62056b 
This works around a more generic solution of sharing evaluators beteen
the document and workspace services, whic is being tracked in #541.
@toinehartman toinehartman mentioned this issue Dec 9, 2024
Open
9 tasks
toinehartman added a commit that referenced this issue Dec 17, 2024
@toinehartman
Move rename files callback to prevent multiple evaluators.
390ae68 
This works around a more generic solution of sharing evaluators beteen
the document and workspace services, whic is being tracked in #541.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavyLandman @toinehartman