Refactoring #34
Open
Refactoring #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usmanyunusov
force-pushed
the
dev
branch
30 times, most recently
from
882b871
to
ef458f7
Compare
usmanyunusov
force-pushed
the
dev
branch
3 times, most recently
from
6cde1e3
to
651e078
Compare
usmanyunusov
force-pushed
the
dev
branch
3 times, most recently
from
dde0ee9
to
f0519d8
Compare
|
Just wanted to say that this branch (and project) is great -- thank you for building it! |
|
@usmanyunusov Any reason this is open? I was toying around with some approaches to chunking on my fork (main) today without changing so much, but looks like that is included in this MR. Very interested in using this vs. manually batching in my merge commits =) |
|
@usmanyunusov Do you plan to merge it soon? Looks like it fixes a lot of failing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.