Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and Document SQL #7

Closed
andreabringhurst opened this issue Aug 6, 2024 · 4 comments
Closed

Review and Document SQL #7

andreabringhurst opened this issue Aug 6, 2024 · 4 comments
Assignees
@andreabringhurst

Comments

@andreabringhurst
Copy link
Collaborator

andreabringhurst commented Aug 6, 2024 •
edited
Loading

  • Read through all the SQL code.
  • Identify the purpose and functionality of each query.
  • Note any immediate issues or areas for improvement.
  • Create consistency in the queries in both structure and output.
  • Add comments explaining the purpose of each query.
  • Document any assumptions or dependencies.
@andreabringhurst andreabringhurst changed the title Review and Cleanup SQL Review and Verify SQL Aug 6, 2024
@andreabringhurst andreabringhurst self-assigned this Aug 6, 2024
@andreabringhurst
Copy link
Collaborator Author

The issues associated with this task are #8 , #9 , and #10

@andreabringhurst andreabringhurst changed the title Review and Verify SQL Review and Document SQL Aug 6, 2024
@andreabringhurst
Copy link
Collaborator Author

andreabringhurst commented Sep 30, 2024 •
edited
Loading

I have moved the due date to Oct. 10 to give me time to work on #10 Retention SQL.

@andreabringhurst
Copy link
Collaborator Author

This is getting moved to paused. The retention sql is ready, but it hasn't been through code review or the Technical subcommittee. This should be saved for the next milestone.

@andreabringhurst andreabringhurst mentioned this issue Nov 9, 2024
Merged
@andreabringhurst
Copy link
Collaborator Author

The remaining SQL that needs to be reviewed is the Validation folder of sql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreabringhurst andreabringhurst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andreabringhurst