Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 14 - Light and Dark theming with toggle button #29

Open
Emmarie-Ahtunan opened this issue Oct 12, 2024 · 8 comments · May be fixed by #71
Open

Feat: 14 - Light and Dark theming with toggle button #29

Emmarie-Ahtunan opened this issue Oct 12, 2024 · 8 comments · May be fixed by #71
Assignees
Labels
enhancement New feature or request gssoc-extd GirlScript Summer of Code involvement hacktoberfest Hacktober fest involvement

Comments

@Emmarie-Ahtunan
Copy link

Is your feature request related to a problem? Please describe.

Yes. The lack of a dark/light theme toggle can lead to eye strain, especially in low-light environments. Users working on the app or website for extended periods may experience discomfort due to the bright screen, which can negatively affect the user experience. Additionally, the inability to switch themes limits personalization and accessibility options for users who prefer dark mode for visual comfort or those with visual impairments.

Describe the Solution You'd Like

I would like to see a dark/light theme toggle added to the user interface, enabling users to seamlessly switch between light and dark themes. The toggle should persist across sessions by saving the user's preference in localStorage or a similar solution. This would improve user comfort and accessibility, especially for those using the app in different lighting conditions or for extended periods.

Describe Alternatives You've Considered

  • Browser extensions: Some extensions allow users to force a dark theme on websites, but this isn't as integrated or user-friendly as a built-in solution.

  • Custom CSS: Adding custom CSS could provide dark mode, but it requires manual setup and lacks the seamless integration and persistence a built-in toggle would offer.

Additional Context

Implementing a dark mode is increasingly standard in modern apps and platforms, providing visual consistency with system-wide dark modes on operating systems like macOS, Windows, iOS, and Android. This feature would enhance usability and make the platform feel more up-to-date. Adding icons (e.g., a moon for dark mode, a sun for light mode) would make the toggle intuitive and easy to find.

@Emmarie-Ahtunan Emmarie-Ahtunan added the enhancement New feature or request label Oct 12, 2024
@utk09-NCL utk09-NCL changed the title Feat: light/dark theme toggle button Feat: 14 - light/dark theme toggle button Oct 13, 2024
@utk09-NCL
Copy link
Owner

Thanks for this @Emmarie-Ahtunan
I think it's a really good idea to have Dark Mode support.

Would you like to code contribute or design contribute to this?

@utk09-NCL utk09-NCL changed the title Feat: 14 - light/dark theme toggle button Feat: 14 - Light and Dark theming with toggle button Oct 13, 2024
@utk09-NCL utk09-NCL added the help wanted Extra attention is needed label Oct 13, 2024
@Emmarie-Ahtunan
Copy link
Author

Emmarie-Ahtunan commented Oct 14, 2024

@utk09-NCL I'd like to work on the design. I worked on the code for a few hours yesterday and still haven't gotten it quite right yet. Let's do the design first, please. Will you assig this to me? Thank you!

@utk09-NCL
Copy link
Owner

Sure @Emmarie-Ahtunan
You can submit the design as a PR as well, details here: https://github.com/utk09-NCL/color-palette-generator/blob/main/design/DESIGN.md

@utk09-NCL utk09-NCL added hacktoberfest Hacktober fest involvement gssoc-extd GirlScript Summer of Code involvement and removed help wanted Extra attention is needed labels Oct 14, 2024
@samorobo
Copy link

@utk09-NCL Good day sir, i would like to work on the light/dark theme toggle, once @Emmarie-Ahtunan is done with the design. Please assign it to me

@Emmarie-Ahtunan
Copy link
Author

/unassign

@utk09-NCL
Copy link
Owner

Sure, @samorobo assigning it to you

@samorobo
Copy link

@utk09-NCL Ok sir. i am just seeing this by tommorow i should have fix this. Thanks

@samorobo
Copy link

samorobo commented Oct 25, 2024

@utk09-NCL i have created a pull request, pls kindly merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-extd GirlScript Summer of Code involvement hacktoberfest Hacktober fest involvement
Projects
None yet
3 participants