Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 18 - Page scroll to top button #32

Open
mohtasheem135 opened this issue Oct 13, 2024 · 8 comments · May be fixed by #46
Open

Feat: 18 - Page scroll to top button #32

mohtasheem135 opened this issue Oct 13, 2024 · 8 comments · May be fixed by #46
Assignees
Labels
enhancement New feature or request gssoc-extd GirlScript Summer of Code involvement hacktoberfest Hacktober fest involvement

Comments

@mohtasheem135
Copy link
Contributor

mohtasheem135 commented Oct 13, 2024

Is your feature request related to a problem? Please describe.
In mobile view when we start scrolling a scroll to top button should appear in the bottom right side and on click it should automatically scroll to the top automatically.

Additional Context
Screenshot_2024-10-13-11-35-49-945_com android chrome

@mohtasheem135 mohtasheem135 added the enhancement New feature or request label Oct 13, 2024
@utk09-NCL
Copy link
Owner

Thanks for this feature request @mohtasheem135
But I don't think that's a problem. Because when user adds more Color Sets, they'll have to scroll up or down anyways.

Please let me know if you think otherwise. Thanks!

@utk09-NCL utk09-NCL changed the title Feat: page scroll down smoothly Feat: page scroll down smoothly <Under Discussion> Oct 13, 2024
@utk09-NCL utk09-NCL added the under-discussion Currently under discussion label Oct 13, 2024
@mohtasheem135
Copy link
Contributor Author

There should be a scroll to the top button too in mobile view for smooth work.

I think it's a good feature, if you feel it should not be added you can close the issue.

@utk09-NCL
Copy link
Owner

I like the idea of "Scroll to Top" button @mohtasheem135. You can Edit your Feature Request template and add details about what is expected.

ideally, it should only be visible when user starts scrolling down and on click of that button, it should scroll the page all the way to the top.

@mohtasheem135
Copy link
Contributor Author

mohtasheem135 commented Oct 13, 2024

Cool, edited the coment.

please assign this to me and add the hactoberfest and gssoc-extd label.

@mohtasheem135 mohtasheem135 changed the title Feat: page scroll down smoothly <Under Discussion> Feat: page scroll to top smoothly <Under Discussion> Oct 13, 2024
@utk09-NCL utk09-NCL added hacktoberfest Hacktober fest involvement gssoc-extd GirlScript Summer of Code involvement labels Oct 13, 2024
@utk09-NCL utk09-NCL changed the title Feat: page scroll to top smoothly <Under Discussion> Feat: 18 - page scroll to top smoothly Oct 13, 2024
@utk09-NCL utk09-NCL changed the title Feat: 18 - page scroll to top smoothly Feat: 18 - Page scroll to top button Oct 13, 2024
@utk09-NCL utk09-NCL removed the under-discussion Currently under discussion label Oct 13, 2024
@mohtasheem135
Copy link
Contributor Author

Hello @utk09-NCL added the scroll to top button. Now to make this interesting, the background colour of "scroll-to-top" button is the base colour of the generated colour.

image

If you want I can share a video of this too,
if you don't like it I can add a static background colour.

@utk09-NCL
Copy link
Owner

Looks good @mohtasheem135
Small nitpicking - Instead of rounded and filled circle, can you make it a squared outline with rounded-sm and the border colour from the base. The UP arrow could be filled triangle like this -

Screenshot 2024-10-14 at 20 53 47

with colour from the base colour

@mohtasheem135
Copy link
Contributor Author

Which you like better?

Option 1:
Screenshot 2024-10-15 232242

Option 2:
Screenshot 2024-10-15 232327

@utk09-NCL
Copy link
Owner

I like the Option 1

@mohtasheem135 mohtasheem135 linked a pull request Oct 15, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-extd GirlScript Summer of Code involvement hacktoberfest Hacktober fest involvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants