Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always calculate the absolute path for the output directory #31

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

juliogonzalez
Copy link
Member

@juliogonzalez juliogonzalez commented Aug 26, 2024

Preparing the documentation on Friday, I noticed that if I used -o package, the build worked, but the package directory didn't contain anything.

Seems this is fixed by always specifying absolute paths when preparing the bind mount for podman, so this PR is precisely calculating that absolute path.

build/en/pdf/uyuni_quickstart_guide.pdf
build/en/pdf/uyuni_client-configuration_guide.pdf
build/en/pdf/uyuni_installation-and-upgrade_guide.pdf
build/en/pdf/uyuni_administration_guide.pdf
build/en/pdf/uyuni_retail_guide.pdf
mkdir -p build/packages
mv uyuni-docs_en.tar.gz uyuni-docs_en-pdf.tar.gz build/packages
[INFO] You can find find the build output at /home/juliogonzalez/Documents/development/git/suse/uyuni-docs-helper/package/build

real    3m49,440s
user    0m0,513s
sys     0m0,279s

$ ls -l /home/juliogonzalez/Documents/development/git/suse/uyuni-docs-helper/package/build
total 8
drwxr-xr-x 5 juliogonzalez users 4096 ago 26 09:49 en
drwxr-xr-x 2 juliogonzalez users 4096 ago 26 09:49 packages

@juliogonzalez juliogonzalez requested a review from nodeg August 26, 2024 08:10
@juliogonzalez juliogonzalez merged commit 27c582a into uyuni-project:main Aug 26, 2024
@juliogonzalez juliogonzalez deleted the fix-output-dir branch August 26, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants