Skip to content

Commit

Permalink
Removed deprecated dataset.reset method
Browse files Browse the repository at this point in the history
  • Loading branch information
JBWilkie committed Feb 7, 2025
1 parent 10d1b3c commit ef80615
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 45 deletions.
4 changes: 1 addition & 3 deletions darwin/cli_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,7 @@ def set_file_status(dataset_slug: str, status: str, files: List[str]) -> None:
files: List[str]
Names of the files we want to update.
"""
available_statuses = ["archived", "clear", "new", "restore-archived", "complete"]
available_statuses = ["archived", "new", "restore-archived", "complete"]
if status not in available_statuses:
_error(
f"Invalid status '{status}', available statuses: {', '.join(available_statuses)}"
Expand All @@ -1075,8 +1075,6 @@ def set_file_status(dataset_slug: str, status: str, files: List[str]) -> None:
)
if status == "archived":
dataset.archive(items)
elif status == "clear":
dataset.reset(items)
elif status == "new":
dataset.move_to_new(items)
elif status == "restore-archived":
Expand Down
11 changes: 0 additions & 11 deletions darwin/dataset/remote_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -499,17 +499,6 @@ def move_to_new(self, items: Iterable[DatasetItem]) -> None:
The ``DatasetItem``\\s whose status will change.
"""

@abstractmethod
def reset(self, items: Iterable[DatasetItem]) -> None:
"""
Resets the given ``DatasetItem``\\s.
Parameters
----------
items : Iterable[DatasetItem]
The ``DatasetItem``\\s to be reset.
"""

@abstractmethod
def complete(self, items: Iterable[DatasetItem]) -> None:
"""
Expand Down
12 changes: 0 additions & 12 deletions darwin/dataset/remote_dataset_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -418,18 +418,6 @@ def move_to_new(self, items: Iterable[DatasetItem]) -> None:
team_slug=self.team,
)

def reset(self, items: Iterable[DatasetItem]) -> None:
"""
Deprecated
Resets the given ``DatasetItem``\\s.
Parameters
----------
items : Iterable[DatasetItem]
The ``DatasetItem``\\s to be resetted.
"""
raise ValueError("Reset is deprecated for version 2 datasets")

def complete(self, items: Iterable[DatasetItem]) -> None:
"""
Completes the given ``DatasetItem``\\s.
Expand Down
19 changes: 0 additions & 19 deletions tests/darwin/cli_functions_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,25 +289,6 @@ def test_calls_dataset_archive(
)
mock.assert_called_once_with(fetch_remote_files_mock.return_value)

def test_calls_dataset_clear(
self, dataset_identifier: str, remote_dataset: RemoteDataset
):
with patch.object(
Client, "get_remote_dataset", return_value=remote_dataset
) as get_remote_dataset_mock:
with patch.object(
RemoteDatasetV2, "fetch_remote_files"
) as fetch_remote_files_mock:
with patch.object(RemoteDatasetV2, "reset") as mock:
set_file_status(dataset_identifier, "clear", ["one.jpg", "two.jpg"])
get_remote_dataset_mock.assert_called_once_with(
dataset_identifier=dataset_identifier
)
fetch_remote_files_mock.assert_called_once_with(
{"item_names": "one.jpg,two.jpg"}
)
mock.assert_called_once_with(fetch_remote_files_mock.return_value)

def test_calls_dataset_new(
self, dataset_identifier: str, remote_dataset: RemoteDataset
):
Expand Down

0 comments on commit ef80615

Please sign in to comment.