Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop search immediately after finding acTL chunk #3

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

madtisa
Copy link

@madtisa madtisa commented Aug 10, 2024

I believe there is no need to continue searching for IDAT if acTL is found, since it's existence is guaranteed by PNG spec

madtisa added 3 commits August 10, 2024 05:33
There is no need to continue searching for `IDAT`,
since it's existence is guaranteed by PNG spec.
Version updates in CI
@vHeemstra
Copy link
Owner

Since this package is not a APNG validator but only a quick recognizer (during batch file processing for example), I agree that we don't need to find the IDAT after acTL.

@vHeemstra vHeemstra merged commit 811fcfa into vHeemstra:main Aug 10, 2024
3 checks passed
@madtisa madtisa deleted the f/finish-search-early branch August 12, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants