New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach onto to amend to init #36

Open

weiliang2 opened this issue Apr 5, 2023 · 0 comments

weiliang2 commented Apr 5, 2023

Hi there,

consider changing "attached on" to init at constructor. We can reuse the component in a application, instead of recreating the object always.

We can just set the src link for the anchor and it should update the download and print button.

Also if you can add support to vaadin 14 would be really helpful.

Great work! This should be a default component.

Thanks for reading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment