Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme compilation fails to detect Vaadin-Stylesheets definitions from manifests of open projects #95

Open
peterl1084 opened this issue Mar 2, 2017 · 0 comments

Comments

@peterl1084
Copy link

When developing an add-on with contained SCSS style sheet it's customary to have a separate test UI project through which the add-on is used for testing purposes. It seems as if in case where an add-on project is open in Eclipse together with the test UI project, the Eclipse Vaadin integration fails to detect the MANIFEST.MF from the add-on and then fails adding the appropriate entries to addons.scss file of the test theme.

The above problem does not occur if CLI is used for compiling the project as with this approach a complete JAR is built containing proper manifest. The problem can be worked around also by closing the add-on project in IDE, leaving only the test UI project open. Then the theme compiler finds the appropriate MANIFEST correctly from the JAR within local .m2 repo.

The problem is simply that when a project defining an internal SCSS style sheet is OPEN in IDE, the theme compilation process fails to detect the MANIFEST from this open add-on project and then fails to include it's theme to the actual theme used in the test UI.

Another way to work around this is to completely disable the theme compilation from the plugin's maven targets and initially make it right through CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant