Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Quotes get removed from url() even if the URL has spaces #312

Open
danipran opened this issue Aug 2, 2017 · 0 comments
Open

Quotes get removed from url() even if the URL has spaces #312

danipran opened this issue Aug 2, 2017 · 0 comments

Comments

@danipran
Copy link

danipran commented Aug 2, 2017

E.g. url("foo bar"); becomes url(foo bar); which in turn results in broken CSS.

I first faced this problem when using custom fonts with the Valo Theme (using the Bourbon font-face mixin) and used a space in the font-family name. This causes the font-face to not load at all (at least in Chrome and Firefox, IE blissfully ignores the rules) because the SVG-format font has a # on its URL.

Suggestions:

  • add/keep quotes if the URL contains spaces
  • replace spaces with %20 (it's one byte more than two quotes so not a good option really)
  • document this "feature" in Vaadin docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant