Shouldn't close on Esc

[heruan]

Despite having set no-close-on-esc in the wrapped vaadin-dialog, pressing Esc closes the dialog.

[jouni]

I’m trying to guess here, but I assume you are perhaps misusing a confirm dialog for some other purpose? 😃

A standard confirm dialog should always be closable with the Esc key, so this issue could be considered “invalid”. But since it should be straightforward to let you do this (just bind the property), it should be alright to fix.

[heruan]

I won't say if your guess is correct or not 😈

But let's consider a proper confirm dialog, which is cancelable and rejectable: I would consider pressing Esc the same as pressing the button "Cancel", but if the dialog isn't cancelable it means I require an explicit choice: "Confirm" or "Reject", therefore in this case it must not close on pressing Esc.

[jouni]

Hmm, true, I skipped that for some reason completely. It seems we’ve skipped that use case completely in our initial design. Thanks for pointing it out 👍

Would you have a good example of this kind of dialog?

[heruan]

The user initiates a transactional processing on the server, which encounters some kind of issue producing the result and needs a user confirmation to be able to proceed or not: the user is prompted with a confirm dialog which asks if the action should be committed or rolled-back, no other choices permitted.

[heruan]

To wrap it up (in my opinion, obviously):

• it should be possible to enable/disable "close on ESC" with an attribute (like in vaadin-dialog), whether or not the dialog is cancelable;

• when the dialog is closed by pressing ESC, a cancel event should be dispatched (as when pressing the "Cancel" button).

This way we can have a dialog which permits to cancel by pressing ESC, but also can force the user to explicitly press the "Cancel" button to close the dialog wihtout any choice; plus, the dialog can force the user to "Accept" or "Reject", as described by the discussed scenarios.