Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend HolidayBase::pop_named to support HolidayBase::get_named lookup param #2137

Open
arkid15r opened this issue Nov 22, 2024 · 0 comments · May be fixed by #2140
Open

Extend HolidayBase::pop_named to support HolidayBase::get_named lookup param #2137

arkid15r opened this issue Nov 22, 2024 · 0 comments · May be fixed by #2140
Labels
good first issue

Comments

@arkid15r
Copy link
Collaborator

Feature Request

Description

HolidayBase::pop_named method should support

contains - case sensitive contains match;
exact - case sensitive exact match;
startswith - case sensitive starts with match;
icontains - case insensitive contains match;
iexact - case insensitive exact match;
istartswith - case insensitive starts with match;

lookup types.

Related Issues

The idea comes from #2129

Proposed Solution

Extend the current functionality while keeping it backward compatible

Additional context

N/A
@arkid15r arkid15r self-assigned this Nov 22, 2024
@arkid15r arkid15r removed their assignment Nov 22, 2024
@wth-d wth-d linked a pull request Nov 26, 2024 that will close this issue
Draft
9 tasks
@arkid15r arkid15r linked a pull request Dec 2, 2024 that will close this issue
Add support for more lookup types to pop_named (as in get_named method) #2140
Draft
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for more lookup types to pop_named (as in get_named method) wth-d/holidays
1 participant
@arkid15r