Optional prometheus #8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure that var.use_eip is true when creating DNS record
MarcMeszaros
force-pushed
the
optional-prometheus
branch
from
5044e74 to
696efc9
Compare
Also add the EIP id to module outputs in case `use_route53` is `false` and user needs access to elastic IP details.
packages installed via the user data script
MarcMeszaros
force-pushed
the
optional-prometheus
branch
from
696efc9 to
40d9df9
Compare
MarcMeszaros
force-pushed
the
optional-prometheus
branch
from
5e23ae9 to
4612aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes prometheus optional by default and opt-in using
var.use_prometheus.It passes in a similarly names
use_prometheusvariable to theuser-data.txttemplate file interpolation call and uses an if condition inside the bash script to skip installing all the prometheus tools. It also moves theufwcommand that enable it for prometheus inside the if block.Note: Assumes PR #6 , #7 are merged in first.
Closes #3