Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revmd17 #48

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Revmd17 #48

merged 5 commits into from
Mar 20, 2024

Conversation

FNTwin
Copy link
Collaborator

@FNTwin FNTwin commented Mar 18, 2024

Checklist:

  • Was this PR discussed in a issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added or an existing one is deleted.
  • Added RevMD17
  • Corrected a bug in the emrging of the isolated atom energies dictionaries that was overwriting some of the internal keys

@FNTwin FNTwin mentioned this pull request Mar 18, 2024
Closed
@FNTwin FNTwin changed the base branch from develop to lin_atom_en March 19, 2024 13:05
@FNTwin FNTwin changed the base branch from lin_atom_en to develop March 19, 2024 13:06
prtos
prtos approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@prtos prtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition . great PR @FNTwin

@FNTwin FNTwin merged commit 3df21cc into develop Mar 20, 2024
5 checks passed
@FNTwin FNTwin deleted the revmd17 branch March 20, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prtos prtos prtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FNTwin @prtos