diff --git a/basic/src/bin/test_prover.rs b/basic/src/bin/test_prover.rs index f754bce7..6cc91f6b 100644 --- a/basic/src/bin/test_prover.rs +++ b/basic/src/bin/test_prover.rs @@ -2,7 +2,7 @@ extern crate core; use p3_baby_bear::BabyBear; use p3_fri::{TwoAdicFriPcs, TwoAdicFriPcsConfig}; -use valida_alu_u32::add::{Add32Instruction, MachineWithAdd32Chip}; +use valida_alu_u32::add::Add32Instruction; use valida_basic::BasicMachine; use valida_cpu::{ BeqInstruction, BneInstruction, Imm32Instruction, JalInstruction, JalvInstruction, @@ -10,10 +10,8 @@ use valida_cpu::{ }; use valida_machine::{ FixedAdviceProvider, Instruction, InstructionWord, Machine, MachineProof, Operands, ProgramROM, - Word, }; -use valida_memory::MachineWithMemoryChip; use valida_opcodes::BYTES_PER_INSTR; use valida_program::MachineWithProgramChip; diff --git a/basic/src/bin/valida.rs b/basic/src/bin/valida.rs index 590f9333..1232ed8b 100644 --- a/basic/src/bin/valida.rs +++ b/basic/src/bin/valida.rs @@ -9,7 +9,7 @@ use p3_baby_bear::BabyBear; use p3_fri::{FriConfig, TwoAdicFriPcs, TwoAdicFriPcsConfig}; use valida_cpu::MachineWithCpuChip; -use valida_machine::{Machine, MachineProof, ProgramROM, StdinAdviceProvider}; +use valida_machine::{Machine, MachineProof, StdinAdviceProvider}; use valida_elf::{load_executable_file, Program}; use valida_program::MachineWithProgramChip; diff --git a/derive/src/lib.rs b/derive/src/lib.rs index 27a8c22d..ba8dc387 100644 --- a/derive/src/lib.rs +++ b/derive/src/lib.rs @@ -10,7 +10,7 @@ use proc_macro::TokenStream; use proc_macro2::TokenStream as TokenStream2; use quote::quote; use syn::parse::{Parse, ParseStream}; -use syn::{spanned::Spanned, Data, Field, Fields, Ident, Type, TypePath}; +use syn::{spanned::Spanned, Data, Field, Fields, Ident}; // TODO: now trivial with a single field struct MachineFields { @@ -162,7 +162,7 @@ fn run_method( .collect::(); let init_static_data: TokenStream2 = match static_data_chip { - Some(static_data_chip) => quote! { + Some(_static_data_chip) => quote! { self.initialize_memory(); }, None => quote! {}, diff --git a/memory/src/stark.rs b/memory/src/stark.rs index b238da2e..cac818bf 100644 --- a/memory/src/stark.rs +++ b/memory/src/stark.rs @@ -1,10 +1,7 @@ -use crate::columns::{MemoryCols, NUM_MEM_COLS}; +use crate::columns::NUM_MEM_COLS; use crate::MemoryChip; -use core::borrow::Borrow; use p3_air::{Air, AirBuilder, BaseAir}; -use p3_field::AbstractField; -use p3_matrix::MatrixRowSlices; impl BaseAir for MemoryChip { fn width(&self) -> usize { diff --git a/program/src/lib.rs b/program/src/lib.rs index 1adea7e4..145171b2 100644 --- a/program/src/lib.rs +++ b/program/src/lib.rs @@ -2,14 +2,13 @@ extern crate alloc; -use crate::columns::{COL_MAP, NUM_PROGRAM_COLS, PREPROCESSED_COL_MAP}; +use crate::columns::NUM_PROGRAM_COLS; use alloc::vec; use alloc::vec::Vec; use valida_bus::MachineWithProgramBus; use valida_machine::{Chip, Interaction, Machine, ProgramROM}; use valida_util::pad_to_power_of_two; -use p3_air::VirtualPairCol; use p3_field::{AbstractField, Field}; use p3_matrix::dense::RowMajorMatrix; use valida_machine::StarkConfig; @@ -48,7 +47,7 @@ where RowMajorMatrix::new(values, NUM_PROGRAM_COLS) } - fn global_receives(&self, machine: &M) -> Vec> { + fn global_receives(&self, _machine: &M) -> Vec> { // let pc = VirtualPairCol::single_preprocessed(PREPROCESSED_COL_MAP.pc); // let opcode = VirtualPairCol::single_preprocessed(PREPROCESSED_COL_MAP.opcode); // let mut fields = vec![pc, opcode]; diff --git a/static_data/src/lib.rs b/static_data/src/lib.rs index df421d14..cbe3615b 100644 --- a/static_data/src/lib.rs +++ b/static_data/src/lib.rs @@ -11,8 +11,8 @@ use p3_air::VirtualPairCol; use p3_field::{AbstractField, Field}; use p3_matrix::dense::RowMajorMatrix; use valida_bus::MachineWithMemBus; -use valida_machine::{BusArgument, Chip, Interaction, Machine, StarkConfig, Word}; -use valida_memory::{MachineWithMemoryChip, MemoryChip}; +use valida_machine::{Chip, Interaction, StarkConfig, Word}; +use valida_memory::MachineWithMemoryChip; pub mod columns; pub mod stark; @@ -57,7 +57,7 @@ where M: MachineWithMemBus, SC: StarkConfig, { - fn generate_trace(&self, machine: &M) -> RowMajorMatrix { + fn generate_trace(&self, _machine: &M) -> RowMajorMatrix { let mut rows = self .cells .iter()