Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should isURL accept accented urls or should make this validation optional? #2424

Open
toofff opened this issue Jun 18, 2024 · 1 comment
Open

Comments

@toofff
Copy link

toofff commented Jun 18, 2024

Describe the bug
The following url are valid: https://my-ùrl.com & https://my-url.coù

Should accented URLs be allowed?

Shouldn't we add an option to invalidate URLs with accents if the option is enabled?

Thank you for your feedback

Additional context
Validator.js version: 13.11.0
Node.js version: 20.11.0
OS platform: windows, linux & macOS

@toofff
Copy link
Author

toofff commented Jun 21, 2024

If there's a development to be made for this pull request, I'm willing to take care of it. I'd just like to know in which direction you want to go with this?

Is this a bug for you?
Or could we create an option not to accept accented urls?

I discovered this problem because my API uses Apache's UrlValidator Java class and accented urls are not accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants