Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add the release-candidate tests to CI #2250

Closed
adarovadya opened this issue Sep 9, 2024 · 1 comment
Closed

Node: Add the release-candidate tests to CI #2250

adarovadya opened this issue Sep 9, 2024 · 1 comment
Labels
backlog Issues/tasks/etc currentlly part of backlog bug Something isn't working node Node.js wrapper python Python wrapper
Milestone

Comments

@adarovadya
Copy link
Collaborator

Describe the bug

The release-candidate tests failed, and we didn't find it during the CI process

Expected Behavior

It is expected that the failour tests will be found during the CI process

Current Behavior

The release-candidate tests failed, and we didn't find it during the CI process

Reproduction Steps

Run the CI process with missing import in the /utils/release-candidate-testing/node/index.js file, the CI will pass

Possible Solution

add build and run the tests as part of the CI

Additional Information/Context

No response

Client version used

Engine type and version

OS

Language

TypeScript

Language Version

Cluster information

No response

Logs

No response

Other information

No response

@adarovadya adarovadya added bug Something isn't working backlog Issues/tasks/etc currentlly part of backlog node Node.js wrapper labels Sep 9, 2024
@adarovadya adarovadya added this to the 1.1 milestone Sep 9, 2024
@Yury-Fridlyand Yury-Fridlyand added the python Python wrapper label Sep 9, 2024
@Yury-Fridlyand
Copy link
Collaborator

Note: for java it is already implemented in #2128 - It runs benchmark with the client RC being published

@ikolomi ikolomi closed this as completed Sep 16, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Valkey-GLIDE - internal Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues/tasks/etc currentlly part of backlog bug Something isn't working node Node.js wrapper python Python wrapper
Projects
Status: Done
Development

No branches or pull requests

3 participants