Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of Futures from UI render code #7

Open
aghassemi opened this issue Nov 23, 2015 · 2 comments
Open

Remove use of Futures from UI render code #7

aghassemi opened this issue Nov 23, 2015 · 2 comments
Assignees
@aghassemi
Labels
Dart

Comments

@aghassemi
Copy link
Contributor

There are a few places in render code we listen to a Future returned by an action to show "toasts" (like starting presentation..., presentation started, etc..) This is not good, we should move those to the state object.
@aghassemi aghassemi self-assigned this Nov 23, 2015
@aghassemi aghassemi added the Dart label Nov 23, 2015
@aghassemi
Copy link
Contributor Author

Also make the public API of all the methods in AppActions void so this can never happen again.

@aghassemi
Copy link
Contributor Author

@asadovsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghassemi aghassemi

Labels
Dart
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aghassemi