Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest release is broken #283

Closed
fountaindive opened this issue Aug 20, 2024 · 2 comments
Closed

latest release is broken #283

fountaindive opened this issue Aug 20, 2024 · 2 comments

Comments

@fountaindive
Copy link

Description

Installing the latest release produces quite a few errors. Is there any chance you could fix them?

e.g. in synthcity/plugins/core/models/survival_analysis/metrics.py I had to update

from scipy.integrate import trapz to from scipy.integrate import trapezoid as trapz

I also needed to install a specific version of pydantic. See this issue

I also needed to edit synthcity/plugins/core/models/tabular_encoder.py go to the OrdinalEncoder and change sparse -> sparse_output

Many thanks!

How to Reproduce

ENV_NAME=py312
conda create -y --name $ENV_NAME python=3.12
conda activate $ENV_NAME
python -m pip install synthcity

Then in python try using synthcity

from synthcity.plugins import Plugins

with traceback

  File "/Users/<USERNAME>/anaconda3/envs/py312/lib/python3.12/site-packages/synthcity/plugins/core/models/survival_analysis/metrics.py", line 8, in <module>
    from scipy.integrate import trapz
ImportError: cannot import name 'trapz' from 'scipy.integrate' (/Users/<USERNAME>/anaconda3/envs/py312/lib/python3.12/site-packages/scipy/integrate/__init__.py)

however, after you fix this trapz error you also get the OrdinalEncoder error when you try to fit a model

Expected Behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

System Information

  • OS: mac
  • OS Version: 14.6.1
  • Language Version: python 3.12
  • Package Manager Version: conda 24.1.2

Additional Context

Add any other context about the problem here.

@robsdavis
Copy link
Contributor

Hi @fountaindive, Unfortunately synthcity does not yet support python 3.12. Please try with python 3.10 to be sure everything works

@fountaindive
Copy link
Author

Hi @robsdavis thanks for getting back to me!

I tried again using python 3.10 but got the same error

ImportError: cannot import name 'trapz' from 'scipy.integrate' (/Users/<USERNAME>/anaconda3/envs/py310/lib/python3.10/site-packages/scipy/integrate/__init__.py)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants