Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: Notification Streams #30

Open
lewislarsen opened this issue Aug 27, 2024 · 1 comment
Open

[Refactor]: Notification Streams #30

lewislarsen opened this issue Aug 27, 2024 · 1 comment
Assignees
Labels
refactor Refactor a part of the codebase

Comments

@lewislarsen
Copy link
Member

Contact Details

No response

Refactoring Title

Improve notification stream

Refactoring Description

Currently the logic mostly lives in the BackupTask model, which was okay when it was just a couple of notification choices but it's getting pretty unweildly.

In the future this should be addressed and extracted into its own set of classes in the app/Services directory.

Notifications are pretty well tested and that's not an area I'm concerned about, but it could do with some love to make it less messy to work on. There doesn't need to be any change in functionality but I am concerned about the code in the long-term.

Current Issues

No response

Additional Context

No response

@lewislarsen lewislarsen added the refactor Refactor a part of the codebase label Aug 27, 2024
@lewislarsen
Copy link
Member Author

lewislarsen commented Dec 29, 2024

Will be tackling this in the new year because it's a part of the codebase I'm not happy with.

@lewislarsen lewislarsen self-assigned this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor a part of the codebase
Projects
None yet
Development

No branches or pull requests

1 participant