Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

items attribute from collection.get_list() should be list[Record], not list[Basemodel] #106

Open
TomTom101 opened this issue Nov 26, 2024 · 1 comment

Comments

@TomTom101
Copy link

@dataclass
class ListResult:
    page: int = 1
    per_page: int = 0
    total_items: int = 0
    total_pages: int = 0
    items: list[BaseModel] = field(default_factory=list)

Would items contain anything other than Records?

@vaphes
Copy link
Owner

vaphes commented Dec 5, 2024

@TomTom101 you're right. the lib needs a refactoring regarding type annotations, you are welcome to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants