Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unzip bug #7

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix unzip bug #7

merged 2 commits into from
Aug 27, 2024

Conversation

fpseverino
Copy link
Member

@fpseverino fpseverino commented Aug 27, 2024

  • Fix a bug where unzipped files were empty
  • Add testing to avoid such issue in the future

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.14%. Comparing base (5ca8997) to head (d00d1ea).
Report is 1 commits behind head on main.

Files Patch % Lines
Sources/Zip/Zip.swift 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files           7        7           
  Lines         337      337           
=======================================
  Hits          324      324           
  Misses         13       13           
Files Coverage Δ
Sources/Zip/Zip.swift 93.36% <90.00%> (ø)

@fpseverino fpseverino requested review from MahdiBM, ptoffy and 0xTim August 27, 2024 18:21
Copy link

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I fully understood what's going on in those c functions, but considering there are tests I'll approve this. Feel free to merge or wait for someone else to review as well 🙂.

Sources/Zip/Zip.swift Outdated Show resolved Hide resolved
@fpseverino fpseverino merged commit 2d2e186 into vapor-community:main Aug 27, 2024
10 checks passed
@fpseverino fpseverino deleted the fix branch August 27, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants