Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SQLiteConnection creation without specifying an event loop #52

Closed
2 tasks
gwynne opened this issue Aug 8, 2023 · 0 comments · Fixed by #56
Closed
2 tasks

Allow SQLiteConnection creation without specifying an event loop #52

gwynne opened this issue Aug 8, 2023 · 0 comments · Fixed by #56
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gwynne
Copy link
Member

gwynne commented Aug 8, 2023

[The equivalent of] cherry-picked from vapor/postgres-nio#388:

SwiftNIO has landed EventLoopGroup and NIOThreadPool singletons in 2.58.0. See apple/swift-nio#2471.

We should add an additional SQLiteConnection open method, that internally uses the existing one, but uses the NIO singletons:

extension SQLiteConnection {
    static func open(
        storage: Storage = .memory,
        logger: Logger = .init(label: "codes.vapor.sqlite")
    ) -> EventLoopFuture<SQLiteConnection> {
        Self.open(
            storage: storage,
            threadPool: NIOThreadPool.singleton,
            logger: logger,
            on: MultiThreadedEventLoopGroup.singleton.any()
        )
    }
}
  • Add API
  • Remove all EventLoopGroup usages in the README
@gwynne gwynne added enhancement New feature or request good first issue Good for newcomers labels Aug 8, 2023
@ptoffy ptoffy self-assigned this Sep 14, 2023
@gwynne gwynne linked a pull request Sep 16, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this to In progress in Beginner Issues Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants