Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pydantic based validation to clinvar_api models #227

Open
holtgrewe opened this issue May 31, 2024 · 0 comments
Open

Add pydantic based validation to clinvar_api models #227

holtgrewe opened this issue May 31, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@holtgrewe
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The submission schema has certain validations (e.g., minimal and maximal number of items). The schema validation results are hard to read, so using pydantic validations would improve ergonomics.

Describe the solution you'd like
Implement the validation where necessary. When a field is "required" then this is already reflected by the type annotations and the field being non-Optional.

Describe alternatives you've considered
N/A

Additional context
N/A

@holtgrewe holtgrewe added the enhancement New feature or request label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant