Variety 0.8.3 missing indicator icon

[martinkg]

Description of problem:

Variety crashes when running it.

Version-Release number of selected component (if applicable):
0.8.3

How reproducible:

Very easy to reproduce, just start variety.

Steps to Reproduce:

1. start variety

Actual results:

➜ ~ variety
WARNING: 2020-03-20 14:24:17,038: load_history() 'Could not load history file, continuing without it, no worries'
WARNING: 2020-03-20 14:24:17,103: create_menu() 'Variety Slideshow is not installed. This is an optional extension adding pan-and-zoom slideshows to Variety: see https://github.com/peterlevi/variety-slideshow for details'
No such schema “org.cinnamon.desktop.background”

(variety:769795): Gtk-CRITICAL **: 14:24:17.216: gtk_widget_get_scale_factor: assertion 'GTK_IS_WIDGET (widget)' failed

Expected results:

variety starts and so does the gnome indicator.

Fedora bugzilla 1672725

[jlu5]

Does the app exit completely after those messages? If so can you follow the instructions at #83 (comment) ?

[rwlove]

When I run '/usr/bin/variety -v' or the below command:

• The gnome notifier crashes immediately
• The the license/configuration dialog pops up
• I agree to the license and don't make any changes to the default settings
• After some time (wallpapers downloading) the wallpapers begin to change
• The gnome notifier never returns.

➜ ~ killall -9 variety
➜ ~ rm ~/.config/variety -rf
➜ ~ python3 -q -X faulthandler /usr/bin/variety
WARNING: 2020-03-24 08:14:55,991: load_history() 'Could not load history file, continuing without it, no worries'
WARNING: 2020-03-24 08:14:56,040: create_menu() 'Variety Slideshow is not installed. This is an optional extension adding pan-and-zoom slideshows to Variety: see https://github.com/peterlevi/variety-slideshow for details'

(variety:1433674): Gtk-CRITICAL **: 08:14:56.445: gtk_widget_get_scale_factor: assertion 'GTK_IS_WIDGET (widget)' failed
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
/usr/lib/python3.7/site-packages/urllib3/connectionpool.py:1004: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
InsecureRequestWarning,
ERROR: 2020-03-24 08:15:11,548: download_one_from() 'Could not download wallpaper:'
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/urllib3/connectionpool.py", line 421, in _make_request
six.raise_from(e, None)
File "", line 3, in raise_from
File "/usr/lib/python3.7/site-packages/urllib3/connectionpool.py", line 416, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
response.begin()
File "/usr/lib64/python3.7/http/client.py", line 306, in begin
version, status, reason = self._read_status()
File "/usr/lib64/python3.7/http/client.py", line 267, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/usr/lib64/python3.7/socket.py", line 589, in readinto
return self._sock.recv_into(b)
File "/usr/lib64/python3.7/ssl.py", line 1071, in recv_into
return self.read(nbytes, buffer)
File "/usr/lib64/python3.7/ssl.py", line 929, in read
return self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/usr/lib/python3.7/site-packages/urllib3/connectionpool.py", line 720, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/usr/lib/python3.7/site-packages/urllib3/util/retry.py", line 400, in increment
raise six.reraise(type(error), error, _stacktrace)
File "/usr/lib/python3.7/site-packages/urllib3/packages/six.py", line 693, in reraise
raise value
File "/usr/lib/python3.7/site-packages/urllib3/connectionpool.py", line 672, in urlopen
chunked=chunked,
File "/usr/lib/python3.7/site-packages/urllib3/connectionpool.py", line 423, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/usr/lib/python3.7/site-packages/urllib3/connectionpool.py", line 331, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='api.desktoppr.co', port=443): Read timed out. (read timeout=5)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 1159, in download_one_from
file = downloader.download_one()
File "/usr/lib/python3.7/site-packages/variety/plugins/downloaders/DefaultDownloader.py", line 141, in download_one
items = self.fill_queue()
File "/usr/lib/python3.7/site-packages/variety/plugins/builtin/downloaders/DesktopprDownloader.py", line 57, in fill_queue
response = Util.fetch_json("https://api.desktoppr.co/1/wallpapers/random", verify=False)
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 643, in fetch_json
return Util.request(url, data, **request_kwargs).json()
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 620, in request
verify=verify,
File "/usr/lib/python3.7/site-packages/requests/api.py", line 60, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/lib/python3.7/site-packages/requests/sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python3.7/site-packages/requests/sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python3.7/site-packages/requests/adapters.py", line 529, in send
raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='api.desktoppr.co', port=443): Read timed out. (read timeout=5)
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/variety/Util.py", line 849, in cb
args0
File "/usr/lib/python3.7/site-packages/variety/VarietyWindow.py", line 841, in _gtk_update
self.ind.show_origin.set_sensitive("noOriginPage" not in info)
TypeError: argument of type 'NoneType' is not iterable
^CTerminating signal received, quitting...

[rwlove]

Variety seems to be running and changing wallpapers. I suppose the only problem I have is that the gnome indicator is missing.

[jlu5]

If it's just the indicator bugging out and the app is still running, I think this is the same issue as #287, which I've fixed in Git master.

[rwlove]

I'm not sure what to say. When I first filed the defect, against Fedora, it seemed like the indicator was crashing and variety wasn't changing the wallpaper. I've since cleared out the config directory and restarted variety, from the command line, multiple times. I've also rebooted.

Now, variety seems to be changing the wallpaper just fine, but the indicator always crashes.

I think we should close this defect and I'll ask Fedora to update their RPM from your master branch to get your indicator fix.

[rwlove]

I tested with the updated RPM and now the gnome indicator does not launch. Previously it launched, but then crashed immediately. Gnome would even give a notification with a message like, "oops variety crashed." This time it just doesn't start.

[jlu5]

Please provide the console output when running Variety or attach ~/.config/variety/variety.log.

I haven't been able to reproduce this, but 8b8bb63 is a fairly theoretical fix based on the traceback (if info is None, don't look for keys inside it).

[rwlove]

typescript.txt

[jlu5]

All I see there is that you used Ctrl-C to quit the app? There isn't any error 😕

[rwlove]

Is this not the pertinent line:

(variety:812996): Gtk-CRITICAL **: 07:44:58.263: gtk_widget_get_scale_factor: assertion 'GTK_IS_WIDGET (widget)' failed

When I run it on the command line, or any other way, variety runs (until I cancel it), but the gnome indicator never appears. I think the issue is reduced to just the gnome indicator missing.

[jlu5]

I'm not sure - Gtk and friends like to throw confusing warnings all the time, often times you can see messages like that without any noticeable impact to the app's function. For example I see (variety:13198): Gdk-CRITICAL **: 12:16:33.574: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed when I run Variety on the console, but things seem to be working fine...

We've had some long running issues with indicators on GNOME since they no longer officially support general tray icons: #12. Unfortunately there's no fix yet aside from using an extension like Ubuntu's AppIndicator or TopIcons-Plus. But even with those we've had mixed results.

[rwlove]

As a data point, the indicator does work on Ubuntu.

[jlu5]

Have you tried installing the AppIndicator extension on Fedora?

[rwlove]

I tried that before filing the defect with Fedora. gnome-shell-extension-appindicator.noarch was the package. I'm not sure if there's something else I need to do, but I simply installed it and it didn't help.