Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyterlab-sos depends on display name of kernel #76

Closed
BoPeng opened this issue Oct 15, 2024 · 2 comments
Closed

jupyterlab-sos depends on display name of kernel #76

BoPeng opened this issue Oct 15, 2024 · 2 comments

Comments

@BoPeng
Copy link
Contributor

BoPeng commented Oct 15, 2024

kernel-dropdown is not displayed for sos kernels with a different display name.

@BoPeng
Copy link
Contributor Author

BoPeng commented Oct 16, 2024

The problem has been partially resolved. More specifically, jupyterlab-sos can now handles non-SoS displayed name, but the kernel name has to be sos for jupyterlab-sos to recognize the sos kernel. That is to say,

  • Kernel my_kernel with displayed name SoS will no longer works, but
  • Kernel sos with name My SoS will work

Ideally, jupyterlab-sos should recognize the kernel by “language”, not by kernel name or displayed name. Unfortunately, jupyterlab does not know the “language” information when the kernel is started so jupyterlab-sos has to guess the language either from kernel_name or display name. I will keep the ticket open and see if there can be a better solution.

@BoPeng
Copy link
Contributor Author

BoPeng commented Oct 16, 2024

Listening to promise context.sessionContext.session?.kernel?.info helped. I need to hide the language dropdown by default, and enable it only for sos kernels to avoid setState for ReactWidget, but this should be the way to go anyway.

@BoPeng BoPeng closed this as completed Oct 16, 2024
BoPeng added a commit that referenced this issue Oct 16, 2024
Fix loading sos when kernel display name is not SoS #76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant