Warning: a promise was rejected with a non-error: [object Object]

[simplecommerce]

Hi,

I started seeing this warning recently in my devtools console whenever I validate a form.
It seems to point to onValidate.

I was wondering if anyone is seeing this also or is it just me?

[radekmie]

From what I checked, it's most likely a Bluebird warning (docs) - can you confirm that? And I guess you're using JSON schema, right? If so, we'll update our docs on how to mitigate it by wrapping the validator result in an error.

[simplecommerce]

@radekmie Hi, I am using GraphQL schema, but I did the following to remove the warning, don't know if its the right way though but it
seems to work.

I created a custom class

class AutoFormValidationError extends Error {
    constructor(details) {
        super("AutoForm Validation Error"); // (1)
        this.name = "AutoFormValidationError"; // (2)
        this.details = details;
    }    
}

And I return it in onValidate , my onValidate returns a promise.

resolve(new AutoFormValidationError(details));

[radekmie]

That's basically what I wanted to suggest. Another option is to use something like Object.assign(new Error(), { details }).

[simplecommerce]

That's basically what I wanted to suggest. Another option is to use something like Object.assign(new Error(), { details }).

Ok cool! I just wasn't sure if using assign like that was the right way to do it or not.
Thanks!!

[simplecommerce]

@radekmie I hope you could help again with this topic. I have a form which I use onValidate to do some async validation and I display errors inline.

This code works:

const onValidate = (model, error) => {
	let details = get(error, "details", []);

	if (!disableRequiredFieldsValidation){
		// append errors
		details = concat(details, schema.validateRequiredFields(model));
	}

	const errorObj = details.length ? { details: details } : error || null;

	// eslint-disable-next-line no-console
	if (!isEmpty(errorObj)) console.error(errorObj);

	if (!isUnmountingRef.current){
		return Promise.resolve(isFunction(onValidateAsProp) ? onValidateAsProp(model, errorObj) : errorObj);
	}
};

I have no issues and I see the errors appear. I wanted to refactor the code so it would look better, so I did the following:

const onValidate = async (model, error) => {
	if (!isUnmountingRef.current){
		let details = get(error, "details", []);

		if (!disableRequiredFieldsValidation){
			// append errors
			details = concat(details, schema.validateRequiredFields(model));
		}

		let errorObj = details.length ? { details: details } : error || null;
		errorObj = isFunction(onValidateAsProp) ? await onValidateAsProp(model, errorObj) : errorObj;

		// eslint-disable-next-line no-console
		if (!isEmpty(errorObj)) console.log(errorObj);

		return errorObj;
	}
};

The 2nd code, no longer displays errors inline and in both cases I keep getting the a promise was rejected with a non-error: [object Object] warning in my console.

I don't see what I am doing wrong or different. I tried to do the same test on a sandbox and the sandbox works fine.
My app is using MeteorJS but the sandbox isn't, so I am thinking maybe it has something to do with that, but it would be weird though.

Any help is appreciated, thanks!

[simplecommerce]

@wadamek65 I am having no luck finding the cause of the async function not returning true as an instance of Promise.
In my test reproduction repo, I installed every package I have in my actual project and I still get true in my test repo but false in my actual project.

I tried to look in every file to see if anything would actually override Promise, but I don't see anything.

Any other ideas? If it is not package related?

[wadamek65]

@simplecommerce Are the build steps the same? Because I would expect it's rather the build system causing this rather than the packages themselves.

Unfortunately, I do not have any other ideas for you. I'm also not 100% sure that what I mentioned is the root of your problem but I think it's highly likely. I could help if you managed to provide me with a minimal reproduction repo, otherwise, maybe @radekmie will have an idea once he comes back to this.

[simplecommerce]

@wadamek65 You were right, I finally was able to pinpoint what was causing it to return false. It was a library I was including in an HTML file.
Removing it, made the console.log return true and the async code returns the errors correctly now.

Thanks for your help!!

[wadamek65]

@simplecommerce No problem, I'm glad your problem is resolved.

[radekmie]

The message itself comes from Bluebird. I know, because I actually mentioned it in the docs, right after this discussion was solved eight months ago 😅 In any case, glad you've solved it!

(I'll note it down that we should extend the docs on this topic even further.)