Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclosed file descriptors of subprocesses #4

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

stotko
Copy link
Member

@stotko stotko commented Jan 31, 2024

During JIT compiling, the stdout and stderr file streams are captured and implicitly closed when the subprocess object is deleted, which however causes a resource warning. Use a context manager to explicitly close the streams and to fix the warning.

@stotko stotko added the fixed label Jan 31, 2024
@stotko stotko merged commit f500f6f into main Jan 31, 2024
13 checks passed
@stotko stotko deleted the subprocess_file_warning branch January 31, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant