Skip to content

Commit

Permalink
fix: eslint
Browse files Browse the repository at this point in the history
  • Loading branch information
davidecarpini committed Oct 24, 2024
1 parent 1622846 commit 0935f5c
Show file tree
Hide file tree
Showing 22 changed files with 216 additions and 122 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
const Config = require('@vechain/repo-config');
export default {
extends: ['plugin:angular/recommended'],

module.exports = {
...Config.EslintLibrary,
rules: {
'no-constant-binary-expression': 'off',
'eslint-comments/disable-enable-pair': 'off',
Expand Down
2 changes: 1 addition & 1 deletion examples/sample-angular-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"clean": "rm -rf dist .turbo .angular",
"dev": "ng serve --port 5004",
"gh-pages-build": "ng build --configuration development --base-href '/vechain-dapp-kit/angular/'",
"lint": "eslint src --ext .js,.jsx,.ts,.tsx",
"lint": "eslint",
"preview": "ng serve --port 5004",
"purge": "yarn clean; rm -rf node_modules",
"watch": "ng build --watch --configuration development"
Expand Down
2 changes: 1 addition & 1 deletion examples/sample-react-app/eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module.exports = {
export default {
root: true,
env: { browser: true, es2020: true },
extends: [
Expand Down
2 changes: 1 addition & 1 deletion examples/sample-react-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"clean": "rm -rf dist .turbo",
"dev": "vite",
"gh-pages-build": "tsc && vite build",
"lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
"lint": "eslint",
"preview": "vite preview --mode=development",
"purge": "yarn clean; rm -rf node_modules",
"test": "vitest"
Expand Down
84 changes: 0 additions & 84 deletions examples/sample-remix-app/.eslintrc.cjs

This file was deleted.

77 changes: 77 additions & 0 deletions examples/sample-remix-app/eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
export default {
root: true,
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
ecmaFeatures: {
jsx: true,
},
},
env: {
browser: true,
commonjs: true,
es6: true,
},
ignorePatterns: ['!**/.server', '!**/.client'],

// Base config
extends: ['eslint:recommended'],

overrides: [
// React
{
files: ['**/*.{js,jsx,ts,tsx}'],
plugins: ['react', 'jsx-a11y'],
extends: [
'plugin:react/recommended',
'plugin:react/jsx-runtime',
'plugin:react-hooks/recommended',
'plugin:jsx-a11y/recommended',
],
settings: {
react: {
version: 'detect',
},
formComponents: ['Form'],
linkComponents: [
{ name: 'Link', linkAttribute: 'to' },
{ name: 'NavLink', linkAttribute: 'to' },
],
'import/resolver': {
typescript: {},
},
},
},

// Typescript
{
files: ['**/*.{ts,tsx}'],
plugins: ['@typescript-eslint', 'import'],
parser: '@typescript-eslint/parser',
settings: {
'import/internal-regex': '^~/',
'import/resolver': {
node: {
extensions: ['.ts', '.tsx'],
},
typescript: {
alwaysTryTypes: true,
},
},
},
extends: [
'plugin:@typescript-eslint/recommended',
'plugin:import/recommended',
'plugin:import/typescript',
],
},

// Node
{
files: ['.eslintrc.cjs'],
env: {
node: true,
},
},
],
};
2 changes: 1 addition & 1 deletion examples/sample-remix-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"build": "remix vite:build --mode=development",
"dev": "remix vite:dev",
"gh-pages-build": "remix vite:build",
"lint": "eslint --ignore-path .gitignore --cache --cache-location ./node_modules/.cache/eslint .",
"lint": "eslint",
"preview": "PORT=5007 remix-serve ./build/server/index.js",
"typecheck": "tsc"
},
Expand Down
8 changes: 0 additions & 8 deletions examples/sample-svelte-app/.eslintrc.cjs

This file was deleted.

5 changes: 5 additions & 0 deletions examples/sample-svelte-app/eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
export default {
rules: {
'no-constant-binary-expression': 'off',
},
};
2 changes: 1 addition & 1 deletion examples/sample-svelte-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"clean": "rm -rf .svelte-kit dist .turbo",
"dev": "vite dev",
"gh-pages-build": "BASE_PATH='/vechain-dapp-kit/svelte' vite build",
"lint": "eslint src --ext .js,.jsx,.ts,.tsx",
"lint": "eslint",
"preview": "vite preview",
"purge": "yarn clean; rm -rf node_modules"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/dapp-kit-react/eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default {
'@vercel/style-guide/eslint/browser',
'@vercel/style-guide/eslint/typescript',
'@vercel/style-guide/eslint/react',
].map(resolve),
],
parserOptions: {
project,
ecmaVersion: 'latest',
Expand Down
2 changes: 1 addition & 1 deletion packages/dapp-kit-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"scripts": {
"build": "tsup",
"clean": "rm -rf dist .turbo",
"lint": "tsc --noEmit && eslint src --ext .js,.jsx,.ts,.tsx",
"lint": "eslint",
"purge": "yarn clean && rm -rf node_modules",
"test": "vitest run --coverage",
"watch": "yarn build --watch"
Expand Down
2 changes: 1 addition & 1 deletion packages/dapp-kit-ui/eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default {
extends: [
'@vercel/style-guide/eslint/node',
'@vercel/style-guide/eslint/typescript',
].map(require.resolve),
],
parserOptions: {
project,
},
Expand Down
2 changes: 1 addition & 1 deletion packages/dapp-kit-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"clean": "rm -rf dist .turbo",
"dev": "rm -rf ../../.parcel-cache; parcel --no-cache index.html",
"format": "prettier \"**/*.{cjs,html,js,json,md,ts}\" --ignore-path ./.eslintignore --write",
"lint": "tsc --noEmit && eslint src --ext .js,.jsx,.ts,.tsx",
"lint": "eslint",
"purge": "yarn clean && rm -rf node_modules",
"test": "vitest run --coverage",
"test:dev": "vitest run ",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { Font, type ThemeMode } from '../../constants';
import { friendlyAddress, getPicassoImage } from '../../utils/account';
import { buttonStyle } from '../../assets/styles';
import { DAppKitUI } from '../../client';
import { shortenedDomain } from '@vechain/dapp-kit';

@customElement('vdk-address-button')
export class AddressButton extends LitElement {
Expand Down Expand Up @@ -86,7 +87,7 @@ export class AddressButton extends LitElement {

const addressOrDomain =
this.accountDomain && !this.isAccountDomainLoading
? this.accountDomain
? shortenedDomain(this.accountDomain, 7)
: friendlyAddress(this.address ?? '');
return html` <vdk-fonts></vdk-fonts>
<button
Expand Down
Loading

0 comments on commit 0935f5c

Please sign in to comment.