Skip to content

Commit

Permalink
refactor: simplify signTypedData method in certificate-wallet and wc-…
Browse files Browse the repository at this point in the history
…wallet
  • Loading branch information
Valazan committed Oct 8, 2024
1 parent 0f97d05 commit 9f75e7e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
5 changes: 2 additions & 3 deletions packages/dapp-kit/src/classes/certificate-wallet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,8 @@ class CertificateBasedWallet implements ConnexWallet {
_types: Record<string, ethers.TypedDataField[]>,
_value: Record<string, unknown>,
_options?: SignTypedDataOptions,
): Promise<string> => {
return this.wallet.signTypedData(_domain, _types, _value);
};
): Promise<string> =>
this.wallet.signTypedData(_domain, _types, _value, _options);

disconnect = async (): Promise<void> => this.wallet.disconnect?.();
}
Expand Down
6 changes: 2 additions & 4 deletions packages/dapp-kit/src/classes/wc-wallet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,8 @@ class WCWallet implements ConnexWallet {
_types: Record<string, ethers.TypedDataField[]>,
_value: Record<string, unknown>,
_options?: SignTypedDataOptions,
): Promise<string> => {
// Delegating the signTypedData to the signer instance
return this.signer.signTypedData(_domain, _types, _value, _options);
};
): Promise<string> =>
this.signer.signTypedData(_domain, _types, _value, _options);

disconnect = (): Promise<void> => this.signer.disconnect();
}
Expand Down

0 comments on commit 9f75e7e

Please sign in to comment.