feat(trace_to_log transform): allows adding a transform that converts traces to logs #22287
+204
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
domain: transforms
pront
reviewed
Jan 27, 2025
Comment on lines
+69
to
+94
| fn schema_definition(log_namespace: LogNamespace) -> Definition { | ||
| let mut schema_definition = Definition::default_for_namespace(&BTreeSet::from([log_namespace])); | ||
|
|
||
| match log_namespace { | ||
| LogNamespace::Vector => { | ||
| schema_definition = schema_definition.with_event_field( | ||
| &owned_value_path!("timestamp"), | ||
| Kind::bytes().or_undefined(), | ||
| None, | ||
| ); | ||
|
|
||
| schema_definition = schema_definition.with_metadata_field( | ||
| &owned_value_path!("vector"), | ||
| Kind::object(Collection::empty()), | ||
| None, | ||
| ); | ||
| } | ||
| LogNamespace::Legacy => { | ||
| if let Some(timestamp_key) = log_schema().timestamp_key() { | ||
| schema_definition = | ||
| schema_definition.with_event_field(timestamp_key, Kind::timestamp(), None); | ||
| } | ||
| } | ||
| } | ||
| schema_definition | ||
| } |
There was a problem hiding this comment.
How do we decide which attributes are available in a trace and how do we map them to a log?
This is related to #20170. IMO this is a simplistic view but we can document here that this is just a naive implementation and once we have a finalized trace model we need to revisit.
pront
reviewed
Jan 27, 2025
Comment on lines
+100
to
+106
| fn transform(&mut self, output: &mut OutputBuffer, event: Event) { | ||
| let log = match event { | ||
| Event::Trace(trace) => LogEvent::from(trace), | ||
| _ => return, | ||
| }; | ||
| output.push(Event::Log(log)); | ||
| } |
There was a problem hiding this comment.
Suggested change
| fn transform(&mut self, output: &mut OutputBuffer, event: Event) { | |
| let log = match event { | |
| Event::Trace(trace) => LogEvent::from(trace), | |
| _ => return, | |
| }; | |
| output.push(Event::Log(log)); | |
| } | |
| impl FunctionTransform for TraceToLog { | |
| fn transform(&mut self, output: &mut OutputBuffer, event: Event) { | |
| if let Event::Trace(trace) = event { | |
| output.push(Event::Log(LogEvent::from(trace))); | |
| } | |
| } | |
| } |
| } | ||
|
|
||
| impl InternalEvent for TraceToLogConversionError { | ||
| fn emit(self) { |
There was a problem hiding this comment.
Did you plan to emit this in fn transform()?
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn transform_trace() { |
There was a problem hiding this comment.
Let's expand the tests. You can use let (actual_map, actual_metadata) = trace_event.into_parts(); and then assert for both.
|
Let's also add a new scope to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
Checklist
make check-allis a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References