Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(azure_blob sink, gcp_cloud_storage sink): Note transparent decompression #21814

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Nov 15, 2024

Summary

Copy note from AWS S3 sink about transparent decompression to other blob storage sinks since another user got tripped up by this for the Azure Blob Storage sink (#21795).

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

n/a

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Ref: #21795

…pression

Copy note from AWS S3 sink.

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Nov 15, 2024
@jszwedko jszwedko requested review from a team as code owners November 15, 2024 21:02
@github-actions github-actions bot added domain: sinks Anything related to the Vector's sinks domain: external docs Anything related to Vector's external, public documentation labels Nov 15, 2024
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful note.

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Nov 15, 2024

Datadog Report

Branch report: jswzedko/note-compression-blob
Commit report: 0f31727
Test service: vector

✅ 0 Failed, 31 Passed, 0 Skipped, 25.45s Total Time

@jszwedko jszwedko added this pull request to the merge queue Nov 15, 2024
Merged via the queue into master with commit 983a993 Nov 15, 2024
66 checks passed
@jszwedko jszwedko deleted the jswzedko/note-compression-blob branch November 15, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants