Fail with an error message when lisp import processing fails in CLI mode #347
Conversation
Returns a non-zero exit code and prints an error message.
Move opening the package output file right before writing. Opening the file already creates a zero-size file on the disk, presumably when the file is closed in the destructor.
|
The code in the PR looks correct, but I'm not sure how the comment relates to this PR. Regarding imports, it is still possible and even quite common to import files from packages in the vesc_pkg repository. They are not downloaded from git, but from the local copy of the archive that includes the binaries. All libraries heavily rely on being able to import files from packages. There are many ways to support importing files that are not present in a path locally. After a lot of thinking this was the best way I could come up with that is easy to implement and does not require installing anything besides VESC Tool. I want users to be able to use libraries from any platform out of the box without installing external tools such as git, so there must be a way for VESC Tool to download and cache them in a simple way. Being able to access the cached file out in the field without internet is also a requirement. For that this approach works perfectly. I'm happy to take constructive feedback, but I'm not prepared to go into any long discussion on why you think it is "just bad" and spend weeks rewriting it. |
Returns a non-zero exit code and prints an error message.
Example output:
The printed message is quite confusing. I think it refers to the old way the packages were built in
vesc_pkg, where there were binaries committed in git and some parts were being pulled out of them. That mechanism was also very confusing to me and I would venture to say the concept is just bad (I can elaborate if needed). Unless that mechanism has a good use case, maybe the functionality could be removed altogether and the above error message simplified. Just a suggestion...