Shutdown command in menu, update COMM_xx enums to match bldc #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matching latest 6.05 firmware COMM_LISP_RPMSG and COMM_SHUTDOWN were missing Signed-off-by: Dado Mista <[email protected]>
vedderb
reviewed
Jan 16, 2024
mobile/Terminal.qml
Outdated
| @@ -113,6 +113,13 @@ Item { | |||
| } | |||
| } | |||
| } | |||
| MenuItem { | |||
| text: "Reboot" | |||
There was a problem hiding this comment.
Should this say Reboot? Also, did you add a curly bracket too much?
There was a problem hiding this comment.
sorry, that was sloppy on my part - fixed and pushed
VESCs with auto-shutdown support can now be powered down via VESC Tool/App Signed-off-by: Dado Mista <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.