Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with -1 coordinates when there is an insertion before the first reference coord #81

Open
kemaleren opened this issue Oct 21, 2017 · 1 comment
Open

Deal with -1 coordinates when there is an insertion before the first reference coord #81

kemaleren opened this issue Oct 21, 2017 · 1 comment
Assignees
@kemaleren
Labels
bug

Comments

@kemaleren
Copy link
Contributor

No description provided.

@kemaleren kemaleren added the bug label Oct 21, 2017
@kemaleren kemaleren self-assigned this Oct 21, 2017
kemaleren added a commit that referenced this issue Oct 21, 2017
@kemaleren
Set first reference coordinate to 1.
ae1be49 
Closes #81.
@kemaleren kemaleren reopened this Oct 25, 2017
@kemaleren
Copy link
Contributor Author

The previous fix breaks the alignment viewer, since the first instance of a reference ID is taken to be the real one.

We should instead support a 0 index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kemaleren kemaleren

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kemaleren