From 31acb0a836ab25040e6f50ab438e9f0d7903290d Mon Sep 17 00:00:00 2001 From: Jon Mease Date: Tue, 30 Jan 2024 15:00:33 -0500 Subject: [PATCH] bin and timeunit can be lifted out of facets as well --- vegafusion-core/src/planning/lift_facet_aggregations.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/vegafusion-core/src/planning/lift_facet_aggregations.rs b/vegafusion-core/src/planning/lift_facet_aggregations.rs index 1a15efc5..86d43f95 100644 --- a/vegafusion-core/src/planning/lift_facet_aggregations.rs +++ b/vegafusion-core/src/planning/lift_facet_aggregations.rs @@ -136,6 +136,14 @@ impl MutChartVisitor for ExtractFacetAggregationsVisitor { lifted_transforms.push(TransformSpec::Filter(tx)); child_dataset.transform.remove(0); } + Some(TransformSpec::Bin(tx)) => { + lifted_transforms.push(TransformSpec::Bin(tx)); + child_dataset.transform.remove(0); + } + Some(TransformSpec::Timeunit(tx)) => { + lifted_transforms.push(TransformSpec::Timeunit(tx)); + child_dataset.transform.remove(0); + } _ => { // Reached unsupported transform type without an aggregation break None;