Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eligibility checks to use the intra-epoch numbers from Core once available #6134

Closed
daunatv opened this issue Mar 28, 2024 · 2 comments
Labels
branch-next Work with dependencies on next Core release bug 🐛 refine

Comments

@daunatv
Copy link

daunatv commented Mar 28, 2024

Description

When setting up a reward with a notional average position requirement that starts in the same epoch as you sent it, the console rewards indicates that you do not fulfil the average position requirement, you do however receive the reward.

Steps to Reproduce

  1. Setup a reward with notional average position requirement that starts in the same epoch as you set it up.
  2. Check rewards page and see if you fulfil the requirement.

Expected behavior

Since the requirement is fulfilled you should qualify for the reward.
See the screenshot where one reward says I have 127k+ average position, while the new reward I just setup that requires 95k says that I do not fulfil the requirement.

Screenshots

Screenshot 2024-03-28 at 13 13 57

@JonRay15
Copy link
Contributor

JonRay15 commented Apr 3, 2024

Wil be covered by vegaprotocol/specs#2239

@JonRay15 JonRay15 moved this from New to Backlog in Frontend Engineering Apr 3, 2024
@JonRay15 JonRay15 changed the title Console Rewards indicates that one does not fulfil average position the epoch the rewards was created. Update eligibility checks to use the intra-epoch numbers from Core once available Apr 25, 2024
@JonRay15 JonRay15 added the branch-main Hot fixes for mainnet ONLY label May 3, 2024
@JonRay15 JonRay15 moved this from Backlog to Todo in Frontend Engineering Jun 3, 2024
@JonRay15 JonRay15 added refine branch-next Work with dependencies on next Core release and removed blocked-by-core branch-main Hot fixes for mainnet ONLY labels Jun 3, 2024
@JonRay15
Copy link
Contributor

JonRay15 commented Jun 4, 2024

Closing this and covering under #6075

@JonRay15 JonRay15 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Frontend Engineering Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-next Work with dependencies on next Core release bug 🐛 refine
Projects
Archived in project
Development

No branches or pull requests

3 participants