Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer "use max" ignores fees which means transfer will fail #6731

Open
davidsiska-vega opened this issue Jul 30, 2024 · 1 comment
Open

Comments

@davidsiska-vega
Copy link

davidsiska-vega commented Jul 30, 2024

Step 1:
image

Step 2:
image

Given that the UI sees the fee it should adjust the final amount that it uses to build the transaction to take the fee into account.

Doing this manually (i.e. press use max, look at fee, subtract fee, press send) works. Not sure it's fool proof because I am not sure where it gets the fee estimate from.

Additional info

Core ticket to do this properly: vegaprotocol/vega#10756

@JonRay15
Copy link
Contributor

JonRay15 commented Aug 8, 2024

I already raised a Core ticket a while ago to do this properly and have a "include fee" mode on theh estimate tranfer fee API.

vegaprotocol/vega#10756

Your proposal would be a reasonable hack ... but not sure we're likely to do it any time soon given other priorities, and would rather the above was just done to do it properly.

@JonRay15 JonRay15 removed their assignment Aug 8, 2024
@JonRay15 JonRay15 moved this from New to Backlog in Frontend Engineering Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants