Merge pull request #11594 from vegaprotocol/11588-fix-panic

fix: actually set err so that the defer to cleanup after amend runs
vegaprotocol · Aug 16, 2024 · ff286ba · ff286ba
2 parents f9a5a29 + 75fd32c
commit ff286ba
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/core/execution/future/market.go b/core/execution/future/market.go
@@ -5589,7 +5589,8 @@ func (m *Market) AmendAMM(ctx context.Context, amend *types.AmendAMM, determinis
 				m.log.Panic("unable to restore AMM balances after failed amend", logging.Error(err))
 			}
 		}
-		return common.ErrAMMCannotRebase
+		err = common.ErrAMMCannotRebase // set it to err so that the defer runs
+		return err
 	}
 
 	m.amm.Confirm(ctx, pool)