Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Volume discount stats API should show volume even if below tier 1 #10218

Closed
1 task
JonRay15 opened this issue Dec 5, 2023 · 0 comments · Fixed by #10232
Closed
1 task

[Feature]: Volume discount stats API should show volume even if below tier 1 #10218

JonRay15 opened this issue Dec 5, 2023 · 0 comments · Fixed by #10232
Assignees
Labels
feature new feature to be developed mainnet-issue

Comments

@JonRay15
Copy link

JonRay15 commented Dec 5, 2023

Feature Overview

Currently the volumeDiscountStats API will only show a record for a party if it has reached enough running volume to qualify for tier 1.

This means that anyone trading some volume who wants to know how close they are to reaching that first tier does not get any useful feedback.

Tasks

A checklist of the tasks that are needed to develop the feature and meet the acceptance criteria and feature test scenarios.

  • Enhance the API to emit an event every epoch even if the party is not in tier 1 or above

Feature test scenarios

Detailed scenarios that can be executed as feature tests to verify that the feature has been implemented as expected.

GIVEN party has some volume but not enough for tier 1
WHEN at the end of the epoch
THEN the API shows the running volume and the fact no discount has been granted

Additional Details (optional)

Any additional information that provides context or gives information that will help us develop the feature.

Small change to Console to make this easier to understand until this is delivered: vegaprotocol/frontend-monorepo#5447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature to be developed mainnet-issue
Projects
Archived in project
Status: In Testing
Development

Successfully merging a pull request may close this issue.

3 participants