Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dispatch strategy on governance transfer proposals #11250

Closed
JonRay15 opened this issue May 9, 2024 · 0 comments · Fixed by #11254
Closed

Missing dispatch strategy on governance transfer proposals #11250

JonRay15 opened this issue May 9, 2024 · 0 comments · Fixed by #11254
Assignees
Labels
api bug fe-request A list of reasonably high value API change requests from front end

Comments

@JonRay15
Copy link

JonRay15 commented May 9, 2024

Summary

There was a bug some time ago due the dispatch stratregy being missing on governance initiated transfers on the transfer API.

It was fixed here: #10945

However, yesterday in dealing with that governance app bug in mainnet it became apparent that the dispatch strategy is also missing on the proposals API, as you can see below.

A27E1698-E9CC-421B-A935-E6DA059C991E

As a result, this ticket to display that info properly in the governance app is currently blocked: vegaprotocol/frontend-monorepo#6388.

Additional Info

Full query below

fragment T on NewTransfer {
  sourceType
  destinationType
  amount
  transferType
  kind {
    ... on RecurringGovernanceTransfer {
      startEpoch
      endEpoch
      dispatchStrategy {
        dispatchMetric
      }
    }
  }
}

query proposals {
  proposalsConnection(proposalType: TYPE_NEW_TRANSFER) {
    edges {
      proposalNode {
        ... on Proposal {
          id
          state
          terms {
            change {
              ... on NewTransfer {
                ...T
              }
            }
          }
        }
        ... on BatchProposal {
          subProposals {
            id
            state
            terms {
              change {
                ... on NewTransfer {
                  ...T
                }
              }
            }
          }
        }
      }
    }
  }
}
@JonRay15 JonRay15 added bug api fe-request A list of reasonably high value API change requests from front end labels May 9, 2024
@ze97286 ze97286 self-assigned this May 9, 2024
@vega-issues vega-issues moved this to Waiting Review in Core Kanban May 9, 2024
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban May 9, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug fe-request A list of reasonably high value API change requests from front end
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants